gh-112092: Fixed contradicting statement#112093
Merged
Merged
Conversation
Statement contradicted itself
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
Bot
added
awaiting review
docs
AlexWaygood
changed the title
Co-authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
ronaldoussoren
added
needs backport to 3.11
ronaldoussoren
approved these changes
Jan 18, 2024
ronaldoussoren
left a comment
ronaldoussoren
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
The new text is better than we had before, and with the last update to the PR there can be no confusion about "3.10" being a major or minor release.
|
Thanks @DerSchinken for the PR, and @ronaldoussoren for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 18, 2024
…honGH-112093) Use different versions in the examples for when extensions do and do not need to be recompiled to make the examples easier to understand. (cherry picked from commit 68a7b78) Co-authored-by: DerSchinken <53398996+DerSchinken@users.noreply.github.com>
|
GH-114260 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 18, 2024
…honGH-112093) Use different versions in the examples for when extensions do and do not need to be recompiled to make the examples easier to understand. (cherry picked from commit 68a7b78) Co-authored-by: DerSchinken <53398996+DerSchinken@users.noreply.github.com>
|
GH-114261 is a backport of this pull request to the 3.11 branch. |
ronaldoussoren
pushed a commit
that referenced
this pull request
Jan 18, 2024
…-112093) (#114260) gh-112092: clarify unstable ABI recompilation requirements (GH-112093) Use different versions in the examples for when extensions do and do not need to be recompiled to make the examples easier to understand. (cherry picked from commit 68a7b78) Co-authored-by: DerSchinken <53398996+DerSchinken@users.noreply.github.com>
ronaldoussoren
pushed a commit
that referenced
this pull request
Jan 18, 2024
…-112093) (#114261) gh-112092: clarify unstable ABI recompilation requirements (GH-112093) Use different versions in the examples for when extensions do and do not need to be recompiled to make the examples easier to understand. (cherry picked from commit 68a7b78) Co-authored-by: DerSchinken <53398996+DerSchinken@users.noreply.github.com>
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
…hon#112093) Use different versions in the examples for when extensions do and do not need to be recompiled to make the examples easier to understand.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…hon#112093) Use different versions in the examples for when extensions do and do not need to be recompiled to make the examples easier to understand.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…hon#112093) Use different versions in the examples for when extensions do and do not need to be recompiled to make the examples easier to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #112092
📚 Documentation preview 📚: https://cpython-previews--112093.org.readthedocs.build/